Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1411423002: Merge to XFA: Remove dead code that was reactivated when fixing overrides. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Remove dead code that was reactivated when fixing overrides. BUG=pdfium:205 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1409743004 . (cherry picked from commit 9ddafc82bddb984ae46ee0df801ba20b446d5158) Committed: https://pdfium.googlesource.com/pdfium/+/a5b47041066011eb590a020bb38035442fce48af

Patch Set 1 #

Patch Set 2 : fix up mismatches #

Patch Set 3 : fix up mismatches, round 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -127 lines) Patch
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 2 chunks +1 line, -7 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_ListBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 2 chunks +1 line, -7 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 2 chunks +1 line, -16 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 1 2 8 chunks +10 lines, -41 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 1 chunk +11 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
TBR, manual merge, but I've double checked against the original.
5 years, 2 months ago (2015-10-19 21:31:38 UTC) #1
Lei Zhang
5 years, 2 months ago (2015-10-19 21:32:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a5b47041066011eb590a020bb38035442fce48af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698