Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(387)

Issue 1409743004: Remove dead code that was reactivated when fixing overrides. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dead code that was reactivated when fixing overrides. BUG=pdfium:205 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9ddafc82bddb984ae46ee0df801ba20b446d5158

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -127 lines) Patch
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 2 chunks +1 line, -7 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_ListBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 2 chunks +1 line, -7 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 2 chunks +1 line, -16 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 8 chunks +10 lines, -41 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 1 chunk +11 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
As you can see on https://codereview.chromium.org/1283493004/diff/1/fpdfsdk/src/formfiller/FFL_FormFiller.cpp line 602, OnKeyStroke() was a harmless function... until it ...
4 years, 11 months ago (2015-10-17 02:21:24 UTC) #2
Tom Sepez
lgtm
4 years, 11 months ago (2015-10-19 20:55:25 UTC) #3
Lei Zhang
4 years, 11 months ago (2015-10-19 21:14:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9ddafc82bddb984ae46ee0df801ba20b446d5158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698