Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1411403012: Merge to XFA: Add path service to retrieve test data directory at run time so tests can be run from… (Closed)

Created:
5 years, 1 month ago by Wei Li
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add path service to retrieve test data directory at run time so tests can be run from any directory. Previously the tests which read test files assume the current directory is under pdfium. Running from any other directory will break the build. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1408003014 . (cherry picked from commit c0e93a9a942fe7d99800502a61d2fbb58cf9276f) Conflicts: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp fpdfsdk/src/fpdfdoc_embeddertest.cpp testing/embedder_test.cpp testing/embedder_test.h Committed: https://pdfium.googlesource.com/pdfium/+/091f7a070d58e1f8de6bbfdc5b60e1cef84e58c3

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove a blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -53 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func_embeddertest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail_embeddertest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfformfill_embeddertest.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 7 chunks +11 lines, -11 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M testing/embedder_test.h View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/embedder_test.cpp View 3 chunks +7 lines, -3 lines 0 comments Download
M testing/test_support.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
A testing/utils/path_service.h View 1 chunk +37 lines, -0 lines 0 comments Download
A testing/utils/path_service.cpp View 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Wei Li
CL https://codereview.chromium.org/1353093003 has not merged into XFA, hence the conflicts.
5 years, 1 month ago (2015-11-09 19:30:29 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/1411403012/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp (right): https://codereview.chromium.org/1411403012/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp#newcode32 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp:32: extra blank line?
5 years, 1 month ago (2015-11-09 19:59:28 UTC) #2
Wei Li
submitting. thanks. https://codereview.chromium.org/1411403012/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp (right): https://codereview.chromium.org/1411403012/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp#newcode32 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp:32: On 2015/11/09 19:59:28, Lei Zhang wrote: > ...
5 years, 1 month ago (2015-11-09 20:09:58 UTC) #3
Wei Li
5 years, 1 month ago (2015-11-09 20:10:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
091f7a070d58e1f8de6bbfdc5b60e1cef84e58c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698