Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2122)

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp

Issue 1411403012: Merge to XFA: Add path service to retrieve test data directory at run time so tests can be run from… (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: remove a blank line Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
index ed2863bcf3fba26681f4f4942daf530721560fc8..87375666191f1f42083e32e055b06f049b8e89d4 100644
--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
@@ -2,19 +2,20 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "../../../testing/embedder_test.h"
+#include "testing/embedder_test.h"
#include "testing/gtest/include/gtest/gtest.h"
class FPDFParserEmbeddertest : public EmbedderTest {};
TEST_F(FPDFParserEmbeddertest, LoadError_454695) {
// Test trailer dictionary with $$ze instead of Size.
- EXPECT_FALSE(OpenDocument("testing/resources/bug_454695.pdf"));
+ // Verify that the defective pdf shouldn't be opened correctly.
+ EXPECT_FALSE(OpenDocument("bug_454695.pdf"));
}
TEST_F(FPDFParserEmbeddertest, Bug_481363) {
// Test colorspace object with malformed dictionary.
- EXPECT_TRUE(OpenDocument("testing/resources/bug_481363.pdf"));
+ EXPECT_TRUE(OpenDocument("bug_481363.pdf"));
FPDF_PAGE page = LoadPage(0);
EXPECT_NE(nullptr, page);
UnloadPage(page);
@@ -22,7 +23,7 @@ TEST_F(FPDFParserEmbeddertest, Bug_481363) {
TEST_F(FPDFParserEmbeddertest, Bug_544880) {
// Test self referencing /Pages object.
- EXPECT_TRUE(OpenDocument("testing/resources/bug_544880.pdf"));
+ EXPECT_TRUE(OpenDocument("bug_544880.pdf"));
// Shouldn't crash. We don't check the return value here because we get the
// the count from the "/Count 1" in the testcase (at the time of writing)
// rather than the actual count (0).

Powered by Google App Engine
This is Rietveld 408576698