Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1411403007: exo: Add minimal support for xdg-shell interface to wayland bindings. (Closed)

Created:
5 years, 1 month ago by reveman
Modified:
5 years ago
Reviewers:
lpique, piman
CC:
chromium-reviews, lpique
Base URL:
https://chromium.googlesource.com/chromium/src.git@weston-third-party
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Add minimal support for xdg-shell interface to wayland bindings. The xdg_shell allows clients to turn a wl_surface into a "real window" which can be dragged, resized, stacked, and moved around by the user. This interface is suited towards traditional desktop environments and is what most wayland clients use today. This patch adds minimal support for this interface. Requests such as move and resize will be added by follow up patches. BUG=549781 Committed: https://crrev.com/be1478830142094ed6b60359e9c8ee96a645f920 Cr-Commit-Position: refs/heads/master@{#362935}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : UTF8ToUTF16 #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -1 line) Patch
M components/exo.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/wayland/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 1 2 3 4 5 4 chunks +188 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
reveman
5 years ago (2015-12-02 21:12:31 UTC) #3
piman
lgtm
5 years ago (2015-12-02 22:16:35 UTC) #4
lpique
https://codereview.chromium.org/1411403007/diff/60001/components/exo/wayland/server.cc File components/exo/wayland/server.cc (right): https://codereview.chromium.org/1411403007/diff/60001/components/exo/wayland/server.cc#newcode716 components/exo/wayland/server.cc:716: ->SetTitle(base::string16(base::ASCIIToUTF16(title))); title is documented as being utf8 encoded. (Note ...
5 years ago (2015-12-02 22:27:29 UTC) #6
reveman
https://codereview.chromium.org/1411403007/diff/60001/components/exo/wayland/server.cc File components/exo/wayland/server.cc (right): https://codereview.chromium.org/1411403007/diff/60001/components/exo/wayland/server.cc#newcode716 components/exo/wayland/server.cc:716: ->SetTitle(base::string16(base::ASCIIToUTF16(title))); On 2015/12/02 at 22:27:29, lpique wrote: > title ...
5 years ago (2015-12-03 06:57:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411403007/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411403007/80001
5 years ago (2015-12-03 06:57:59 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411403007/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411403007/100001
5 years ago (2015-12-03 07:13:06 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 08:15:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411403007/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411403007/100001
5 years ago (2015-12-03 08:16:49 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-03 08:24:25 UTC) #18
commit-bot: I haz the power
5 years ago (2015-12-03 08:26:16 UTC) #20
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/be1478830142094ed6b60359e9c8ee96a645f920
Cr-Commit-Position: refs/heads/master@{#362935}

Powered by Google App Engine
This is Rietveld 408576698