Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1492803004: exo: Add SetGeometry function to ShellSurface class. (Closed)

Created:
5 years ago by reveman
Modified:
5 years ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@exosphere-xdg-shell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Add SetGeometry function to ShellSurface class. This adds a SetGeometry function to the ShellSurface class and wayland bindings use that to implement xdg_surface_set_window_geometry. The geometry of a window is its "visible bounds" from the user's perspective. Client-side decorations often have invisible portions like drop-shadows which should be ignored for the purposes of aligning, placing and constraining windows. BUG=549781 TEST=exo_unittests --gtest_filter=ShellSurfaceTest.SetGeometry Committed: https://crrev.com/3fb35f332b2e597adc1a89abc4e898fae9f307ea Cr-Commit-Position: refs/heads/master@{#363086}

Patch Set 1 #

Patch Set 2 : implement xdg_surface_set_window_geometry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M components/exo/shell_surface.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/exo/shell_surface.cc View 3 chunks +17 lines, -1 line 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492803004/1
5 years ago (2015-12-03 15:03:03 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 15:41:05 UTC) #4
reveman
5 years ago (2015-12-03 15:42:41 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492803004/20001
5 years ago (2015-12-03 15:52:19 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 16:41:21 UTC) #10
piman
lgtm
5 years ago (2015-12-03 22:46:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492803004/20001
5 years ago (2015-12-03 23:10:48 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-04 01:19:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492803004/20001
5 years ago (2015-12-04 01:24:10 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-04 01:44:34 UTC) #18
commit-bot: I haz the power
5 years ago (2015-12-04 01:46:02 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3fb35f332b2e597adc1a89abc4e898fae9f307ea
Cr-Commit-Position: refs/heads/master@{#363086}

Powered by Google App Engine
This is Rietveld 408576698