runtime/vm/assembler_arm64.cc - Issue 1411383004: Enable generation of instruction buffer on precompilation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 1411383004: Enable generation of instruction buffer on precompilation (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/assembler_arm64.cc

diff --git a/runtime/vm/assembler_arm64.cc b/runtime/vm/assembler_arm64.cc

index 06203d20194d602684eff64b346e1833028de297..ba2e6eec4f4b4ad42e363ed89b9aad70e7018738 100644

--- a/runtime/vm/assembler_arm64.cc

+++ b/runtime/vm/assembler_arm64.cc

@@ -14,7 +14,7 @@

#include "vm/stub_code.h"

// An extra check since we are assuming the existence of /proc/cpuinfo below.

-#if !defined(USING_SIMULATOR) && !defined(__linux__) && !defined(ANDROID)

+#if !defined(USING_SIMULATOR) && !defined(__linux__) && !defined(ANDROID) && !TARGET_OS_IOS

Cutch 2015/10/21 22:00:08 80 columns

rmacnak 2015/10/21 23:06:18 Same guard on arm32.

rmacnak 2015/10/21 23:06:18 Zach, is this needed on ARM64? As far as I know w

Chinmay 2015/10/22 00:13:17 ack

#error ARM64 cross-compile only supported on Linux

#endif