Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: runtime/tools/create_snapshot_bin.py

Issue 1411383004: Enable generation of instruction buffer on precompilation (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/tools/create_snapshot_bin.py
diff --git a/runtime/tools/create_snapshot_bin.py b/runtime/tools/create_snapshot_bin.py
index b91de38e86353a40e7e1ed131e3840161aeda87b..8da6a0f5adf7751c088c5661db8fdf286850e966 100755
--- a/runtime/tools/create_snapshot_bin.py
+++ b/runtime/tools/create_snapshot_bin.py
@@ -32,6 +32,13 @@ def BuildOptions():
action="store", type="string",
help="output file name into which isolate snapshot in binary form " +
"is generated")
+ result.add_option("--instructions_bin",
+ action="store", type="string",
+ help="output file name into which instructions snapshot in binary form " +
rmacnak 2015/10/21 23:06:18 It's in assembly form, not binary form.
Chinmay 2015/10/22 00:13:17 ack
+ "is generated")
+ result.add_option("--vm_entry_points_manifest",
+ action="store", type="string",
+ help="input manifest with the vm entry points in a precompiled snapshot")
result.add_option("--script",
action="store", type="string",
help="Dart script for which snapshot is to be generated")
@@ -108,6 +115,16 @@ def Main():
options.vm_output_bin ]))
script_args.append(''.join([ "--isolate_snapshot=", options.output_bin ]))
+ # Setup the instuctions snapshot output filename
+ if options.instructions_bin:
+ script_args.append(''.join([ "--instructions_snapshot=",
+ options.instructions_bin ]))
+
+ # Specify the VM entry points snapshot
+ if options.vm_entry_points_manifest:
+ script_args.append(''.join([ "--vm_entry_points_manifest=",
+ options.vm_entry_points_manifest ]))
+
# Next setup all url mapping options specified.
for url_arg in options.url_mapping:
url_mapping_argument = ''.join(["--url_mapping=", url_arg ])

Powered by Google App Engine
This is Rietveld 408576698