Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1411313004: Bypass containing block size special-code for fixed-positioneds when printing. (Closed)

Created:
5 years, 2 months ago by mstensho (USE GERRIT)
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bypass containing block size special-code for fixed-positioneds when printing. Consulting FrameView during printing doesn't really provide reliable results, since class might just know the size of what we have on the screen. While the size of their containing block (i.e. the page) is now calculated correctly when printing, note that fixed positioned objects are still not repeated on every page as they should according to the spec; they are still only printed on the first page. But at least with the correct size and position now. :) BUG=544797 R=leviw@chromium.org Committed: https://crrev.com/d68346d7b83e31397b1c8e7b52ad7642bbaa3579 Cr-Commit-Position: refs/heads/master@{#355893}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/printing/fixed-positioned.html View 1 chunk +7 lines, -0 lines 2 comments Download
A + third_party/WebKit/LayoutTests/printing/fixed-positioned-expected.html View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
mstensho (USE GERRIT)
Printing is a mess. :( But I think this change makes sense. Not quite sure ...
5 years, 2 months ago (2015-10-23 18:38:49 UTC) #1
leviw_travelin_and_unemployed
Yeah. Printing hasn't gotten much love. LGTM. https://codereview.chromium.org/1411313004/diff/1/third_party/WebKit/LayoutTests/printing/fixed-positioned.html File third_party/WebKit/LayoutTests/printing/fixed-positioned.html (right): https://codereview.chromium.org/1411313004/diff/1/third_party/WebKit/LayoutTests/printing/fixed-positioned.html#newcode6 third_party/WebKit/LayoutTests/printing/fixed-positioned.html:6: <div style="position:fixed; ...
5 years, 2 months ago (2015-10-23 19:42:58 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/1411313004/diff/1/third_party/WebKit/LayoutTests/printing/fixed-positioned.html File third_party/WebKit/LayoutTests/printing/fixed-positioned.html (right): https://codereview.chromium.org/1411313004/diff/1/third_party/WebKit/LayoutTests/printing/fixed-positioned.html#newcode6 third_party/WebKit/LayoutTests/printing/fixed-positioned.html:6: <div style="position:fixed; top:0; left:0; right:0; bottom:0; border:5px solid yellow;"></div> ...
5 years, 2 months ago (2015-10-23 19:49:44 UTC) #3
leviw_travelin_and_unemployed
On 2015/10/23 at 19:49:44, mstensho wrote: > https://codereview.chromium.org/1411313004/diff/1/third_party/WebKit/LayoutTests/printing/fixed-positioned.html > File third_party/WebKit/LayoutTests/printing/fixed-positioned.html (right): > > https://codereview.chromium.org/1411313004/diff/1/third_party/WebKit/LayoutTests/printing/fixed-positioned.html#newcode6 ...
5 years, 2 months ago (2015-10-23 19:52:55 UTC) #4
mstensho (USE GERRIT)
On 2015/10/23 19:52:55, leviw wrote: > On 2015/10/23 at 19:49:44, mstensho wrote: > > > ...
5 years, 2 months ago (2015-10-23 20:11:14 UTC) #5
leviw_travelin_and_unemployed
On 2015/10/23 at 20:11:14, mstensho wrote: > On 2015/10/23 19:52:55, leviw wrote: > > On ...
5 years, 2 months ago (2015-10-23 20:12:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411313004/1
5 years, 2 months ago (2015-10-23 20:21:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 21:37:29 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 21:38:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d68346d7b83e31397b1c8e7b52ad7642bbaa3579
Cr-Commit-Position: refs/heads/master@{#355893}

Powered by Google App Engine
This is Rietveld 408576698