third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1411313004: Bypass containing block size special-code for fixed-positioneds when printing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1411313004: Bypass containing block size special-code for fixed-positioneds when printing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/printing/fixed-positioned.html ('K') | « third_party/WebKit/LayoutTests/printing/fixed-positioned-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 15fa2e07ca658736df4a6257d6befc6bdf59c775..9cd08824b0e41dcb89336555f65d221f4e932db2 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2836,7 +2836,7 @@ LayoutUnit LayoutBox::containingBlockLogicalWidthForPositioned(const LayoutBoxMo

return containingBlockLogicalHeightForPositioned(containingBlock, false);

// Use viewport as container for top-level fixed-position elements.

- if (style()->position() == FixedPosition && containingBlock->isLayoutView()) {

+ if (style()->position() == FixedPosition && containingBlock->isLayoutView() && !document().printing()) {

const LayoutView* view = toLayoutView(containingBlock);

if (FrameView* frameView = view->frameView()) {

// Don't use visibleContentRect since the PaintLayer's size has not been set yet.

@@ -2880,7 +2880,7 @@ LayoutUnit LayoutBox::containingBlockLogicalHeightForPositioned(const LayoutBoxM