Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1411203010: Separate RenderViewHost from RenderWidgetHost, part 4: delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: oops Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index c13e70c5a318e77eddb6fa45a73c492229a25469..6fc25e4494d1304f44202638f80f689b7cffdeb7 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -1462,9 +1462,6 @@ gfx::Range RenderWidgetHostViewMac::ConvertCharacterRangeToCompositionRange(
}
WebContents* RenderWidgetHostViewMac::GetWebContents() {
- if (!render_widget_host_->IsRenderView())
- return NULL;
-
return WebContents::FromRenderViewHost(
RenderViewHost::From(render_widget_host_));
}
@@ -2750,15 +2747,15 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
}
SEL action = [item action];
+ BOOL is_render_view =
+ RenderViewHost::From(renderWidgetHostView_->render_widget_host_) !=
+ nullptr;
- if (action == @selector(stopSpeaking:)) {
- return renderWidgetHostView_->render_widget_host_->IsRenderView() &&
- renderWidgetHostView_->IsSpeaking();
- }
- if (action == @selector(startSpeaking:)) {
- return renderWidgetHostView_->render_widget_host_->IsRenderView() &&
- renderWidgetHostView_->SupportsSpeech();
- }
+ if (action == @selector(stopSpeaking:))
+ return is_render_view && renderWidgetHostView_->IsSpeaking();
+
+ if (action == @selector(startSpeaking:))
+ return is_render_view && renderWidgetHostView_->SupportsSpeech();
// For now, these actions are always enabled for render view,
// this is sub-optimal.
@@ -2770,7 +2767,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
action == @selector(copyToFindPboard:) ||
action == @selector(paste:) ||
action == @selector(pasteAndMatchStyle:)) {
- return renderWidgetHostView_->render_widget_host_->IsRenderView();
+ return is_render_view;
}
return editCommand_helper_->IsMenuItemEnabled(action, self);

Powered by Google App Engine
This is Rietveld 408576698