Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: chrome/browser/task_manager/guest_information.cc

Issue 1411203010: Separate RenderViewHost from RenderWidgetHost, part 4: delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: oops Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/guest_information.cc
diff --git a/chrome/browser/task_manager/guest_information.cc b/chrome/browser/task_manager/guest_information.cc
index a71fe8b06908a623fb4f88eb29df93807dd01bcc..63f1f7b7db791f24c469421a63252bbd75223e51 100644
--- a/chrome/browser/task_manager/guest_information.cc
+++ b/chrome/browser/task_manager/guest_information.cc
@@ -108,12 +108,10 @@ void GuestInformation::GetAll(const NewWebContentsCallback& callback) {
scoped_ptr<content::RenderWidgetHostIterator> widgets(
content::RenderWidgetHost::GetRenderWidgetHosts());
while (content::RenderWidgetHost* widget = widgets->GetNextHost()) {
- if (widget->IsRenderView()) {
- content::RenderViewHost* rvh = content::RenderViewHost::From(widget);
- WebContents* web_contents = WebContents::FromRenderViewHost(rvh);
- if (web_contents && GuestViewBase::IsGuest(web_contents))
- callback.Run(web_contents);
- }
+ content::RenderViewHost* rvh = content::RenderViewHost::From(widget);
+ WebContents* web_contents = WebContents::FromRenderViewHost(rvh);
sky 2015/10/26 21:07:38 Same comment here about chrome/browser/extensions/
Avi (use Gerrit) 2015/10/26 23:20:14 Same answer here. As of this CL, it is safe to pas
+ if (web_contents && GuestViewBase::IsGuest(web_contents))
+ callback.Run(web_contents);
}
}

Powered by Google App Engine
This is Rietveld 408576698