content/browser/frame_host/render_frame_host_manager.cc - Issue 1411203010: Separate RenderViewHost from RenderWidgetHost, part 4: delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1411203010: Separate RenderViewHost from RenderWidgetHost, part 4: delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: oops Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_manager/guest_information.cc ('K') | « content/browser/accessibility/accessibility_ui.cc ('k') | content/browser/renderer_host/ime_adapter_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index 059e2b9e72775815ced7079c24b5ec767a3c3a9a..6b6e5ca90895ae6986cc53555c8bf5be22887475 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -2304,10 +2304,9 @@ void RenderFrameHostManager::ShutdownProxiesIfLastActiveFrameInSiteInstance(

scoped_ptr<RenderWidgetHostIterator> widgets(

RenderWidgetHostImpl::GetAllRenderWidgetHosts());

while (RenderWidgetHost* widget = widgets->GetNextHost()) {

- if (!widget->IsRenderView())

+ RenderViewHost* rvh = RenderViewHost::From(widget);

+ if (!rvh)

continue;

- RenderViewHostImpl* rvh =

- static_cast<RenderViewHostImpl*>(RenderViewHost::From(widget));

if (site_instance_id == rvh->GetSiteInstance()->GetId()) {

// This deletes all RenderFrameHosts using the |rvh|, which then causes

// |rvh| to Shutdown.