Separate RenderViewHost from RenderWidgetHost, part 4: delegate

chrome/browser/task_manager/guest_information.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/guest_information.h"
 
 #include "base/strings/string16.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/task_manager/renderer_resource.h"
@@ skipping 90 matching lines @@
 
 bool GuestInformation::CheckOwnership(WebContents* web_contents) {
   // Guest WebContentses are created and owned internally by the content layer.
   return GuestViewBase::IsGuest(web_contents);
 }
 
 void GuestInformation::GetAll(const NewWebContentsCallback& callback) {
   scoped_ptr<content::RenderWidgetHostIterator> widgets(
       content::RenderWidgetHost::GetRenderWidgetHosts());
   while (content::RenderWidgetHost* widget = widgets->GetNextHost()) {
-    if (widget->IsRenderView()) {
-      content::RenderViewHost* rvh = content::RenderViewHost::From(widget);
-      WebContents* web_contents = WebContents::FromRenderViewHost(rvh);
-      if (web_contents && GuestViewBase::IsGuest(web_contents))
-        callback.Run(web_contents);
-    }
+    content::RenderViewHost* rvh = content::RenderViewHost::From(widget);
+    WebContents* web_contents = WebContents::FromRenderViewHost(rvh);

[sky, 2015/10/26 21:07:38]

Same comment here about chrome/browser/extensions/api/processes/processes_api.cc
.

[Avi (use Gerrit), 2015/10/26 23:20:14]

Same answer here. As of this CL, it is safe to pass in null to
WebContents::FromRenderViewHost and you will get a null WebContents back.

+    if (web_contents && GuestViewBase::IsGuest(web_contents))
+      callback.Run(web_contents);
   }
 }
 
 scoped_ptr<RendererResource> GuestInformation::MakeResource(
     WebContents* web_contents) {
   return scoped_ptr<RendererResource>(
       new GuestResource(web_contents->GetRenderViewHost()));
 }
 
 }  // namespace task_manager