ios/build/bots/chromium.mac/iOS_Device_GN.json - Issue 1411183010: Make MB aware of iOS bot configs and get iOS working.

Unified Diff: ios/build/bots/chromium.mac/iOS_Device_GN.json

Issue 1411183010: Make MB aware of iOS bot configs and get iOS working. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add passthrough mode to MB, move MB configuration into //ios files Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/build/bots/chromium.mac/iOS_Device_GN.json

diff --git a/ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json b/ios/build/bots/chromium.mac/iOS_Device_GN.json

similarity index 53%

copy from ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json

copy to ios/build/bots/chromium.mac/iOS_Device_GN.json

index 54408813aab494e758ccd026b133cb8d3d0f71f7..58a341ae7f35c5bfb9833e715ba4945e06d600e5 100644

--- a/ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json

+++ b/ios/build/bots/chromium.mac/iOS_Device_GN.json

@@ -1,15 +1,14 @@

{

"owners": [

+ "dpranke",

"smut"

"comments": [

- "Builder for fat binaries using ninja."

+ "GN + Ninja fat binary builder."

"xcode version": "7.0",

- "GYP_DEFINES": {

- "chromium_ios_signing": "0",

- "target_subarch": "both"

- },

+ "mb_type": "gn",

+ "gn_args": "target_os=\"ios\" target_cpu=\"arm\" ios_enable_code_signing=false",

Dirk Pranke 2015/11/10 02:10:01 I'm waffling as to whether we should make the conf

smut 2015/11/10 22:08:37 Both were specified in the .pyl anyways so both mi

Dirk Pranke 2015/11/10 22:46:06 See my reply in the other CL.

"compiler": "ninja",

"configuration": "Release",

"sdk": "iphoneos9.0",

« no previous file with comments | « BUILD.gn ('k') | ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json » ('j') | tools/mb/mb_config.pyl » ('J')