ios/build/bots/chromium.mac/iOS_Device_GN.json - Issue 1411183010: Make MB aware of iOS bot configs and get iOS working.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/build/bots/chromium.mac/iOS_Device_GN.json

Issue 1411183010: Make MB aware of iOS bot configs and get iOS working. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add passthrough mode to MB, move MB configuration into //ios files Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "owners": [	2 "owners": [

	3 "dpranke",

3 "smut"	4 "smut"

4 ],	5 ],

5 "comments": [	6 "comments": [

6 "Builder for fat binaries using ninja."	7 "GN + Ninja fat binary builder."

7 ],	8 ],

8 "xcode version": "7.0",	9 "xcode version": "7.0",

9 "GYP_DEFINES": {	10 "mb_type": "gn",

10 "chromium_ios_signing": "0",	11 "gn_args": "target_os=\"ios\" target_cpu=\"arm\" ios_enable_code_signing=false ",
	Dirk Pranke 2015/11/10 02:10:01 I'm waffling as to whether we should make the conf I'm waffling as to whether we should make the config files specify both the GYP_DEFINES and gn_args, even if only one will be used. There are two reasons to specify both: 1) Some gclient hooks will change what they do based on GYP_DEFINES settings, so if we don't set the GYP_DEFINES the wrong thing might happen. At a quick look, it didn't seem like any of the iOS hooks did this, but it's a risk. 2) If we specify both in the file, then switching between them is a one line (simple) change that would not involve looking up how to translate one set of args to the other. The downside of specifying both is that it's perhaps unnecessarily verbose and duplicative. smut 2015/11/10 22:08:37 Both were specified in the .pyl anyways so both mi Show quoted text On 2015/11/10 02:10:01, Dirk Pranke wrote: > I'm waffling as to whether we should make the config files > specify both the GYP_DEFINES and gn_args, even if only > one will be used. > > There are two reasons to specify both: > > 1) Some gclient hooks will change what they do based on > GYP_DEFINES settings, so if we don't set the GYP_DEFINES > the wrong thing might happen. At a quick look, it didn't > seem like any of the iOS hooks did this, but it's a risk. > > 2) If we specify both in the file, then switching between > them is a one line (simple) change that would not involve > looking up how to translate one set of args to the other. > > The downside of specifying both is that it's perhaps > unnecessarily verbose and duplicative. Both were specified in the .pyl anyways so both might as well be specified here. But I'd prefer to specify gn_args in a dict like gyp_defines. Dirk Pranke 2015/11/10 22:46:06 See my reply in the other CL. Show quoted text On 2015/11/10 22:08:37, smut wrote: > But I'd prefer to specify gn_args in a dict like gyp_defines. See my reply in the other CL.
11 "target_subarch": "both"

12 },

13 "compiler": "ninja",	12 "compiler": "ninja",

14 "configuration": "Release",	13 "configuration": "Release",

15 "sdk": "iphoneos9.0",	14 "sdk": "iphoneos9.0",

16 "tests": [	15 "tests": [

17 ]	16 ]

18 }	17 }

OLD	NEW

« no previous file with comments | « BUILD.gn ('k') | ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json » ('j') | tools/mb/mb_config.pyl » ('J')