Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1411183009: [DevTools] Narrow down DevToolsNetworkInterceptor::Throttable. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Narrow down DevToolsNetworkInterceptor::Throttable. To achieve this, we remove transaction from interceptor upon failure. BUG=none Committed: https://crrev.com/aec2e4130bc2a2b8db6d6c921a05e8d18c4b80c9 Cr-Commit-Position: refs/heads/master@{#358729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M chrome/browser/devtools/devtools_network_controller_unittest.cc View 2 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_network_interceptor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_network_interceptor.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_network_transaction.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_network_transaction.cc View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
5 years, 1 month ago (2015-11-06 18:17:53 UTC) #3
pfeldman
lgtm
5 years, 1 month ago (2015-11-09 23:08:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411183009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411183009/1
5 years, 1 month ago (2015-11-09 23:11:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 01:27:10 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 01:28:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aec2e4130bc2a2b8db6d6c921a05e8d18c4b80c9
Cr-Commit-Position: refs/heads/master@{#358729}

Powered by Google App Engine
This is Rietveld 408576698