Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6771)

Unified Diff: chrome/browser/devtools/devtools_network_controller_unittest.cc

Issue 1411183009: [DevTools] Narrow down DevToolsNetworkInterceptor::Throttable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_network_interceptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_network_controller_unittest.cc
diff --git a/chrome/browser/devtools/devtools_network_controller_unittest.cc b/chrome/browser/devtools/devtools_network_controller_unittest.cc
index 0abcc5db9cf93f298b1ef27ea204107e6db177af..b399bb1a74b64809c04512ed13cb2141e51880af 100644
--- a/chrome/browser/devtools/devtools_network_controller_unittest.cc
+++ b/chrome/browser/devtools/devtools_network_controller_unittest.cc
@@ -84,7 +84,20 @@ class DevToolsNetworkControllerHelper {
}
bool ShouldFail() {
- return transaction_->interceptor_->ShouldFail();
+ if (transaction_->interceptor_)
+ return transaction_->interceptor_->ShouldFail();
+ base::WeakPtr<DevToolsNetworkInterceptor> interceptor =
+ controller_.GetInterceptor(kClientId);
+ EXPECT_TRUE(!!interceptor);
+ return interceptor->ShouldFail();
+ }
+
+ bool HasStarted() {
+ return !!transaction_->request_;
+ }
+
+ bool HasFailed() {
+ return transaction_->failed_;
}
~DevToolsNetworkControllerHelper() {
@@ -184,10 +197,10 @@ TEST(DevToolsNetworkControllerTest, ReadAfterFail) {
int rv = helper.Start();
EXPECT_EQ(rv, net::OK);
- EXPECT_TRUE(helper.transaction()->HasStarted());
+ EXPECT_TRUE(helper.HasStarted());
helper.SetNetworkState(kClientId, true);
- EXPECT_TRUE(helper.transaction()->HasFailed());
+ EXPECT_TRUE(helper.HasFailed());
scoped_refptr<net::IOBuffer> buffer(new net::IOBuffer(64));
rv = helper.Read();
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_network_interceptor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698