Android GTest Runner: Create flags & test list files only when required

testing/android/native_test/native_test_launcher.cc

Index: testing/android/native_test/native_test_launcher.cc
diff --git a/testing/android/native_test/native_test_launcher.cc b/testing/android/native_test/native_test_launcher.cc
index ae24e3ffcef9f1bf125726e55d45c91727b9a23f..0f14ff9f52c8364f6d2d962da26ff0ffa86cba1b 100644
--- a/testing/android/native_test/native_test_launcher.cc
+++ b/testing/android/native_test/native_test_launcher.cc
@@ -36,11 +36,6 @@ namespace android {
 
 namespace {
 
-// The test runner script writes the command line file in
-// "/data/local/tmp".
-static const char kCommandLineFilePath[] =
-    "/data/local/tmp/chrome-native-tests-command-line";
-
 const char kLogTag[] = "chromium";
 const char kCrashedMarker[] = "[ CRASHED      ]\n";
 
@@ -89,7 +84,7 @@ static void RunTests(JNIEnv* env,
   const std::string command_line_file_path(
       base::android::ConvertJavaStringToUTF8(env, jcommand_line_file_path));
   if (command_line_file_path.empty())
-    ParseArgsFromCommandLineFile(kCommandLineFilePath, &args);
+    args.push_back("_");

[Yaron, 2015/10/20 18:03:02]

Just wondering if this breaks a possible dev flow: what if I want to use the
default file for setting flags? Does test_runner overwrite it always so that's
not possible?

[jbudorick, 2015/10/20 18:08:49]

The test runner currently doesn't overwrite the file, but it does provide its
own. The else branch would be taken here, and you'd never hit this line. (I
think the if branch in the current code has been dead code for about a month.)

After this CL, the default file still won't be used, but the test runner
sometimes won't pass a command-line file of its own, in which case we hit this
code path.

[agrieve, 2015/10/20 18:11:07]

Yeah, tried to code search this as much as I could, but it seems that
test_runner.py is *the* way to run gunit tests, and it always specifies a flag
file.

Certainly looking for guidance though if there is another way to run them.

   else
     ParseArgsFromCommandLineFile(command_line_file_path.c_str(), &args);