Android GTest Runner: Create flags & test list files only when required

testing/android/native_test/native_test_launcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class sets up the environment for running the native tests inside an
 // android application. It outputs (to a fifo) markers identifying the
 // START/PASSED/CRASH of the test suite, FAILURE/SUCCESS of individual tests,
 // etc.
 // These markers are read by the test runner script to generate test results.
 // It installs signal handlers to detect crashes.
@@ skipping 18 matching lines @@
 #include "testing/android/native_test/native_test_util.h"
 
 // The main function of the program to be wrapped as a test apk.
 extern int main(int argc, char** argv);
 
 namespace testing {
 namespace android {
 
 namespace {
 
-// The test runner script writes the command line file in
-// "/data/local/tmp".
-static const char kCommandLineFilePath[] =
-    "/data/local/tmp/chrome-native-tests-command-line";
-
 const char kLogTag[] = "chromium";
 const char kCrashedMarker[] = "[ CRASHED      ]\n";
 
 // The list of signals which are considered to be crashes.
 const int kExceptionSignals[] = {
   SIGSEGV, SIGABRT, SIGFPE, SIGILL, SIGBUS, -1
 };
 
 struct sigaction g_old_sa[NSIG];
 
@@ skipping 28 matching lines @@
 
   // Set the application context in base.
   base::android::InitApplicationContext(env, app_context);
   base::android::RegisterJni(env);
 
   std::vector<std::string> args;
 
   const std::string command_line_file_path(
       base::android::ConvertJavaStringToUTF8(env, jcommand_line_file_path));
   if (command_line_file_path.empty())
-    ParseArgsFromCommandLineFile(kCommandLineFilePath, &args);
+    args.push_back("_");

[Yaron, 2015/10/20 18:03:02]

Just wondering if this breaks a possible dev flow: what if I want to use the
default file for setting flags? Does test_runner overwrite it always so that's
not possible?

[jbudorick, 2015/10/20 18:08:49]

The test runner currently doesn't overwrite the file, but it does provide its
own. The else branch would be taken here, and you'd never hit this line. (I
think the if branch in the current code has been dead code for about a month.)

After this CL, the default file still won't be used, but the test runner
sometimes won't pass a command-line file of its own, in which case we hit this
code path.

[agrieve, 2015/10/20 18:11:07]

Yeah, tried to code search this as much as I could, but it seems that
test_runner.py is *the* way to run gunit tests, and it always specifies a flag
file.

Certainly looking for guidance though if there is another way to run them.

   else
     ParseArgsFromCommandLineFile(command_line_file_path.c_str(), &args);
 
   const std::string command_line_flags(
       base::android::ConvertJavaStringToUTF8(env, jcommand_line_flags));
   ParseArgsFromString(command_line_flags, &args);
 
   std::vector<char*> argv;
   int argc = ArgsToArgv(args, &argv);
 
@@ skipping 47 matching lines @@
   sa.sa_sigaction = SignalHandler;
   sa.sa_flags = SA_SIGINFO;
 
   for (unsigned int i = 0; kExceptionSignals[i] != -1; ++i) {
     sigaction(kExceptionSignals[i], &sa, &g_old_sa[kExceptionSignals[i]]);
   }
 }
 
 }  // namespace android
 }  // namespace testing