Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 141113003: Refactor base/safe_numerics.h (Closed)

Created:
6 years, 11 months ago by jschuh
Modified:
6 years, 11 months ago
Reviewers:
brettw, jam
CC:
chromium-reviews, vandebo (ex-Chrome), tzik, dcheng, kinuko+watch, Ilya Sherman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jar (doing other things), grt+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, fischman+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org, Lei Zhang, mcasas+watch_chromium.org, tommycli, Greg Billock, wjia+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Refactor base/safe_numerics.h * Move into base/numerics subdirectory. * Rename files for clarity. * Add owners. * Rename checked_numeric_cast to checked_cast. * Fixup callsites and include paths. BUG=332611 R=brettw@chromium.org, jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245418

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -653 lines) Patch
M base/base.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/build_utf8_validator_tables.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M base/metrics/histogram_delta_serialization.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A base/numerics/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + base/numerics/safe_conversions.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
A + base/numerics/safe_conversions_impl.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + base/numerics/safe_numerics_unittest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
D base/safe_numerics.h View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
D base/safe_numerics_impl.h View 1 2 1 chunk +0 lines, -183 lines 0 comments Download
D base/safe_numerics_unittest.cc View 1 2 1 chunk +0 lines, -279 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/test_extension_dir.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/linux/mtp_read_file_worker.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/linux/snapshot_file_details.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/crl_set_fetcher.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_manager_metrics_util.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_manager_util_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/extensions/unpacker.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/printer_state.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/cloud/resource_cache.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_truetype_font_list_host.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/speech/google_streaming_remote_engine_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/vibration/vibration_message_filter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/vibration/vibration_provider_android.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/common/child_process_sandbox_support_impl_linux.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_truetype_font_linux.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_video_source_host.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/mock_google_streaming_server.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/media_codec_bridge.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M media/base/audio_bus.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_basic_stream.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M net/websockets/websocket_channel.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_channel_test.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/host/error_conversion.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M printing/image.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M printing/print_destination_win.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/imagediff/image_diff.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_win.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M ui/snapshot/snapshot_aura.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/print_document_source.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/print_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jschuh
@brettw - This is just moving base/safe_numerics.h -> base/numerics/safe_conversions.h and renaming checked_numeric_cast to checked_cast. Everything ...
6 years, 11 months ago (2014-01-16 21:29:30 UTC) #1
brettw
lgtm https://codereview.chromium.org/141113003/diff/360001/base/numerics/OWNERS File base/numerics/OWNERS (right): https://codereview.chromium.org/141113003/diff/360001/base/numerics/OWNERS#newcode1 base/numerics/OWNERS:1: jschuh@chromium.org This is fine, but please check with ...
6 years, 11 months ago (2014-01-16 23:11:21 UTC) #2
jschuh
https://codereview.chromium.org/141113003/diff/360001/base/numerics/OWNERS File base/numerics/OWNERS (right): https://codereview.chromium.org/141113003/diff/360001/base/numerics/OWNERS#newcode1 base/numerics/OWNERS:1: jschuh@chromium.org On 2014/01/16 23:11:22, brettw wrote: > This is ...
6 years, 11 months ago (2014-01-16 23:18:47 UTC) #3
jam
you don't need all these reviewers, just one owner from base and you can skip ...
6 years, 11 months ago (2014-01-17 01:18:54 UTC) #4
jschuh
https://codereview.chromium.org/141113003/diff/550001/base/numerics/safe_conversions.h File base/numerics/safe_conversions.h (right): https://codereview.chromium.org/141113003/diff/550001/base/numerics/safe_conversions.h#newcode5 base/numerics/safe_conversions.h:5: #ifndef BASE_SAFE_NUMERICS_H_ On 2014/01/17 01:18:55, jam wrote: > nit: ...
6 years, 11 months ago (2014-01-17 02:37:50 UTC) #5
jschuh
6 years, 11 months ago (2014-01-17 03:32:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r245418 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698