Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Side by Side Diff: base/numerics/safe_conversions.h

Issue 141113003: Refactor base/safe_numerics.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_SAFE_NUMERICS_H_ 5 #ifndef BASE_SAFE_NUMERICS_H_
jam 2014/01/17 01:18:55 nit: update
jschuh 2014/01/17 02:37:51 Done.
6 #define BASE_SAFE_NUMERICS_H_ 6 #define BASE_SAFE_NUMERICS_H_
7 7
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/safe_numerics_impl.h" 11 #include "base/numerics/safe_conversions_impl.h"
12 12
13 namespace base { 13 namespace base {
14 14
15 // Convenience function that returns true if the supplied value is in range 15 // Convenience function that returns true if the supplied value is in range
16 // for the destination type. 16 // for the destination type.
17 template <typename Dst, typename Src> 17 template <typename Dst, typename Src>
18 inline bool IsValueInRangeForNumericType(Src value) { 18 inline bool IsValueInRangeForNumericType(Src value) {
19 return internal::RangeCheck<Dst>(value) == internal::TYPE_VALID; 19 return internal::RangeCheck<Dst>(value) == internal::TYPE_VALID;
20 } 20 }
21 21
22 // checked_numeric_cast<> is analogous to static_cast<> for numeric types, 22 // checked_cast<> is analogous to static_cast<> for numeric types,
23 // except that it CHECKs that the specified numeric conversion will not 23 // except that it CHECKs that the specified numeric conversion will not
24 // overflow or underflow. NaN source will always trigger a CHECK. 24 // overflow or underflow. NaN source will always trigger a CHECK.
25 template <typename Dst, typename Src> 25 template <typename Dst, typename Src>
26 inline Dst checked_numeric_cast(Src value) { 26 inline Dst checked_cast(Src value) {
27 CHECK(IsValueInRangeForNumericType<Dst>(value)); 27 CHECK(IsValueInRangeForNumericType<Dst>(value));
28 return static_cast<Dst>(value); 28 return static_cast<Dst>(value);
29 } 29 }
30 30
31 // saturated_cast<> is analogous to static_cast<> for numeric types, except 31 // saturated_cast<> is analogous to static_cast<> for numeric types, except
32 // that the specified numeric conversion will saturate rather than overflow or 32 // that the specified numeric conversion will saturate rather than overflow or
33 // underflow. NaN assignment to an integral will trigger a CHECK condition. 33 // underflow. NaN assignment to an integral will trigger a CHECK condition.
34 template <typename Dst, typename Src> 34 template <typename Dst, typename Src>
35 inline Dst saturated_cast(Src value) { 35 inline Dst saturated_cast(Src value) {
36 // Optimization for floating point values, which already saturate. 36 // Optimization for floating point values, which already saturate.
(...skipping 16 matching lines...) Expand all
53 return std::numeric_limits<Dst>::max(); 53 return std::numeric_limits<Dst>::max();
54 } 54 }
55 55
56 NOTREACHED(); 56 NOTREACHED();
57 return static_cast<Dst>(value); 57 return static_cast<Dst>(value);
58 } 58 }
59 59
60 } // namespace base 60 } // namespace base
61 61
62 #endif // BASE_SAFE_NUMERICS_H_ 62 #endif // BASE_SAFE_NUMERICS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698