Issue 1411123011: win: Don't attempt to read a nonexistent IMAGE_DIRECTORY_ENTRY_DEBUG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411123011: win: Don't attempt to read a nonexistent IMAGE_DIRECTORY_ENTRY_DEBUG (Closed)

Created:
5 years, 1 month ago by Mark Mentovai

Modified:
5 years, 1 month ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: Don't attempt to read a nonexistent IMAGE_DIRECTORY_ENTRY_DEBUG BUG=crashpad:1 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ad9887ee0dc016a0131f0518cf602bb8dd380799

Patch Set 2 : Address review feedback #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -10 lines)			Patch
	M	snapshot/win/pe_image_reader.h	View	1	1 chunk	+17 lines, -2 lines	0 comments	Download
	M	snapshot/win/pe_image_reader.cc	View	1	5 chunks	+20 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scottmg

lgtm https://codereview.chromium.org/1411123011/diff/1/snapshot/win/pe_image_reader.h File snapshot/win/pe_image_reader.h (right): https://codereview.chromium.org/1411123011/diff/1/snapshot/win/pe_image_reader.h#newcode134 snapshot/win/pe_image_reader.h:134: bool ReadNtHeaders(WinVMAddress* nt_headers_address, Maybe it'd be nice to ...

5 years, 1 month ago (2015-10-28 19:55:11 UTC) #3

Mark Mentovai

5 years, 1 month ago (2015-10-28 20:42:40 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ad9887ee0dc016a0131f0518cf602bb8dd380799 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1411123011: win: Don't attempt to read a nonexistent IMAGE_DIRECTORY_ENTRY_DEBUG (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review feedback #

Messages