win: Don't attempt to read a nonexistent IMAGE_DIRECTORY_ENTRY_DEBUG

snapshot/win/pe_image_reader.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 91 matching lines @@
   //! \param[out] pdbname Name of the pdb file.
   //! \return `true` on success, or `false` if the module has no debug directory
   //!     entry.
   bool DebugDirectoryInformation(UUID* uuid,
                                  DWORD* age,
                                  std::string* pdbname) const;
 
  private:
   //! \brief Implementation helper for DebugDirectoryInformation() templated by
   //!     `IMAGE_NT_HEADERS` type for different bitnesses.
+  //!
+  //! \return `true` on success, with the parameters set appropriately. `false`
+  //!     on failure. This method may return `false` without logging anything in
+  //!     the case of a module that does not contain relevant debugging
+  //!     information but is otherwise properly structured.
   template <class NtHeadersType>
   bool ReadDebugDirectoryInformation(UUID* uuid,
                                      DWORD* age,
                                      std::string* pdbname) const;
 
   //! \brief Reads the `IMAGE_NT_HEADERS` from the beginning of the image.
+  //!
+  //! \param[out] nt_headers The contents of the templated NtHeadersType
+  //!     structure read from the remote process.
+  //! \param[out] nt_headers_address The address of the templated NtHeadersType
+  //!     structure in the remote process’ address space. If this information is
+  //!     not needed, this parameter may be `nullptr`.
+  //!
+  //! \return `true` on success, with \a nt_headers and optionally \a
+  //!     nt_headers_address set appropriately. `false` on failure, with a
+  //!     message logged.
   template <class NtHeadersType>
-  bool ReadNtHeaders(WinVMAddress* nt_header_address,
-                     NtHeadersType* nt_headers) const;
+  bool ReadNtHeaders(NtHeadersType* nt_headers,
+                     WinVMAddress* nt_headers_address) const;
 
   //! \brief Finds a given section by name in the image.
   template <class NtHeadersType>
   bool GetSectionByName(const std::string& name,
                         IMAGE_SECTION_HEADER* section) const;
 
   //! \brief Reads memory from target process, first checking whether the range
   //!     requested falls inside module_range_.
   //!
   //! \return `true` on success, with \a into filled out, otherwise `false` and
   //!     a message will be logged.
   bool CheckedReadMemory(WinVMAddress address,
                          WinVMSize size,
                          void* into) const;
 
   ProcessReaderWin* process_reader_;  // weak
   CheckedWinAddressRange module_range_;
   std::string module_name_;
   InitializationStateDcheck initialized_;
 
   DISALLOW_COPY_AND_ASSIGN(PEImageReader);
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_SNAPSHOT_WIN_PE_IMAGE_READER_H_