Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1411123002: Fix crash in SiteEngagementServiceHelper when switching render view hosts. (Closed)

Created:
5 years, 2 months ago by calamity
Modified:
5 years, 2 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@startup_timer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in SiteEngagementServiceHelper when switching render view hosts. This CL fixes a crash where the RVH would switch on a WebContents that had input tracking paused. The host was not being switched out for a paused InputTracker, causing the tracking to be added to the stale RVH. BUG=544211 Committed: https://crrev.com/b1893018fff3234b87c000c16f2b76926b8cbb6a Cr-Commit-Position: refs/heads/master@{#354930}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : address comments #

Patch Set 4 : rebase #

Patch Set 5 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M chrome/browser/engagement/site_engagement_helper.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/engagement/site_engagement_helper.cc View 1 2 3 4 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service_browsertest.cc View 1 2 3 chunks +23 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
calamity
5 years, 2 months ago (2015-10-19 03:41:17 UTC) #3
benwells
Can we remove is_active_ and have IsActive() { return host_; } instead? That might let ...
5 years, 2 months ago (2015-10-19 03:56:39 UTC) #4
calamity
On 2015/10/19 03:56:39, benwells wrote: > Can we remove is_active_ and have IsActive() { return ...
5 years, 2 months ago (2015-10-19 06:11:00 UTC) #5
benwells
lgtm
5 years, 2 months ago (2015-10-19 06:14:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411123002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411123002/100001
5 years, 2 months ago (2015-10-20 00:13:25 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 2 months ago (2015-10-20 00:19:38 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 00:20:36 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b1893018fff3234b87c000c16f2b76926b8cbb6a
Cr-Commit-Position: refs/heads/master@{#354930}

Powered by Google App Engine
This is Rietveld 408576698