Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3155)

Unified Diff: chrome/browser/engagement/site_engagement_helper.h

Issue 1411123002: Fix crash in SiteEngagementServiceHelper when switching render view hosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_timer
Patch Set: fix compile Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/site_engagement_helper.h
diff --git a/chrome/browser/engagement/site_engagement_helper.h b/chrome/browser/engagement/site_engagement_helper.h
index 68d4f32b390e9bb736150f1b9ccf8f6fcf5ee80f..c7f9e65206c2c8dd1790fa0e15dda265a945baed 100644
--- a/chrome/browser/engagement/site_engagement_helper.h
+++ b/chrome/browser/engagement/site_engagement_helper.h
@@ -78,12 +78,14 @@ class SiteEngagementHelper
void Stop();
// Returns whether the InputTracker has been started for a RenderViewHost.
- bool is_active() const { return is_active_; }
+ bool IsActive() const;
// Returns whether input tracking callbacks have been added to
// RenderViewHost.
bool is_tracking() const { return is_tracking_; }
+ content::RenderViewHost* host() const { return host_; }
+
// Set the timer object for testing purposes.
void SetPauseTimerForTesting(scoped_ptr<base::Timer> timer);
@@ -100,7 +102,6 @@ class SiteEngagementHelper
content::RenderViewHost* host_;
content::RenderWidgetHost::KeyPressEventCallback key_press_event_callback_;
content::RenderWidgetHost::MouseEventCallback mouse_event_callback_;
- bool is_active_;
bool is_tracking_;
};
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698