Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2163)

Unified Diff: net/quic/quic_crypto_client_stream_test.cc

Issue 1411063004: Remove insecure QUIC support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_crypto_client_stream_test.cc
diff --git a/net/quic/quic_crypto_client_stream_test.cc b/net/quic/quic_crypto_client_stream_test.cc
index 882ff347b9c1e3698a0ba2453e7b2623ecf7ee48..eed2a70516647d74c93cbe444f8045662cdb3e62 100644
--- a/net/quic/quic_crypto_client_stream_test.cc
+++ b/net/quic/quic_crypto_client_stream_test.cc
@@ -24,13 +24,14 @@ namespace net {
namespace test {
namespace {
-const char kServerHostname[] = "example.com";
-const uint16 kServerPort = 80;
+const char kServerHostname[] = "test.example.com";
+const uint16 kServerPort = 443;
class QuicCryptoClientStreamTest : public ::testing::Test {
public:
QuicCryptoClientStreamTest()
- : server_id_(kServerHostname, kServerPort, false, PRIVACY_MODE_DISABLED) {
+ : server_id_(kServerHostname, kServerPort, PRIVACY_MODE_DISABLED),
+ crypto_config_(CryptoTestUtils::ProofVerifierForTesting()) {
CreateConnection();
}
@@ -115,17 +116,6 @@ TEST_F(QuicCryptoClientStreamTest, NegotiatedParameters) {
EXPECT_EQ(crypto_config_.kexs[0], crypto_params.key_exchange);
}
-TEST_F(QuicCryptoClientStreamTest, InvalidHostname) {
- server_id_ =
- QuicServerId("invalid", kServerPort, false, PRIVACY_MODE_DISABLED);
-
- CreateConnection();
-
- CompleteCryptoHandshake();
- EXPECT_TRUE(stream()->encryption_established());
- EXPECT_TRUE(stream()->handshake_confirmed());
-}
-
TEST_F(QuicCryptoClientStreamTest, ExpiredServerConfig) {
// Seed the config with a cached server config.
CompleteCryptoHandshake();
@@ -208,9 +198,11 @@ TEST_F(QuicCryptoClientStreamTest, ServerConfigUpdateBeforeHandshake) {
class QuicCryptoClientStreamStatelessTest : public ::testing::Test {
public:
QuicCryptoClientStreamStatelessTest()
- : server_crypto_config_(QuicCryptoServerConfig::TESTING,
- QuicRandom::GetInstance()),
- server_id_(kServerHostname, kServerPort, false, PRIVACY_MODE_DISABLED) {
+ : client_crypto_config_(CryptoTestUtils::ProofVerifierForTesting()),
+ server_crypto_config_(QuicCryptoServerConfig::TESTING,
+ QuicRandom::GetInstance(),
+ CryptoTestUtils::ProofSourceForTesting()),
+ server_id_(kServerHostname, kServerPort, PRIVACY_MODE_DISABLED) {
TestQuicSpdyClientSession* client_session = nullptr;
CreateClientSessionForTest(server_id_,
/* supports_stateless_rejects= */ true,

Powered by Google App Engine
This is Rietveld 408576698