Remove insecure QUIC support

Remove insecure QUIC support

Require a ProofSource in QuicCryptoServerConfig
  (this includes requiring SSL config for secure quic listeners)
Require a ProofVerifier in QuicCryptoClientConfig.
Remove is_https from QuicServerId.
Remove is_secure from QuicServer.

Merge internal change: 103869607

Committed: https://crrev.com/1fe2eeb3fc63f3bce4793333ed59e1f3fe94e02c
Cr-Commit-Position: refs/heads/master@{#356047}

[Ryan Hamilton, 2015-10-21 04:21:55]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[ramant (doing other things), 2015-10-21 04:43:24]

Hi Ryan,
  Was about to integrate the following CL (you had reviewed) with the master
after your insecure CL was landed. They look very close.

  Your changes look good to me (LGTM). Will take a closer look tomorrow.

https://codereview.chromium.org/1397983007/diff/20001/net/http/http_server_pr...

https://codereview.chromium.org/1411063004/diff/1/net/http/http_server_proper...
File net/http/http_server_properties_manager_unittest.cc (right):

https://codereview.chromium.org/1411063004/diff/1/net/http/http_server_proper...
net/http/http_server_properties_manager_unittest.cc:962:
"{\"quic_servers\":{\"http://"
nit: I think this needs to be https.

https://codereview.chromium.org/1411063004/diff/1/net/tools/quic/end_to_end_t...
File net/tools/quic/end_to_end_test.cc (right):

https://codereview.chromium.org/1411063004/diff/1/net/tools/quic/end_to_end_t...
net/tools/quic/end_to_end_test.cc:373: new
QuicServer(CryptoTestUtils::ProofSourceForTesting(), server_config_,
nit: Shouldn't we use QuicTestServer for Dale's bi-directional code.

[Ryan Hamilton, 2015-10-21 16:45:37]

rch@chromium.org changed reviewers:
+ wez@chromium.org

[Ryan Hamilton, 2015-10-21 16:45:38]

wez: remoting/ OWNERS review please

[Wez, 2015-10-21 16:49:38]

lgtm

[Ryan Hamilton, 2015-10-21 16:56:07]

Thanks, Raman!

https://codereview.chromium.org/1411063004/diff/1/net/http/http_server_proper...
File net/http/http_server_properties_manager_unittest.cc (right):

https://codereview.chromium.org/1411063004/diff/1/net/http/http_server_proper...
net/http/http_server_properties_manager_unittest.cc:962:
"{\"quic_servers\":{\"http://"
On 2015/10/21 04:43:24, ramant wrote:
> nit: I think this needs to be https.
> 

Good point! Thanks. Done.

https://codereview.chromium.org/1411063004/diff/1/net/tools/quic/end_to_end_t...
File net/tools/quic/end_to_end_test.cc (right):

https://codereview.chromium.org/1411063004/diff/1/net/tools/quic/end_to_end_t...
net/tools/quic/end_to_end_test.cc:373: new
QuicServer(CryptoTestUtils::ProofSourceForTesting(), server_config_,
On 2015/10/21 04:43:24, ramant wrote:
> nit: Shouldn't we use QuicTestServer for Dale's bi-directional code.

Definitely. Curiously though, I ran the end to end tests and I thought they
passed. *ponder*

[Ryan Hamilton, 2015-10-23 03:02:07]

rch@chromium.org changed reviewers:
+ mef@chromium.org

[Ryan Hamilton, 2015-10-23 03:02:08]

mef: can you give an OWNERS review for components/cronet?

[mef, 2015-10-23 14:38:46]

lgtm, woohoo!

[Ryan Hamilton, 2015-10-23 19:39:53]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-10-23 19:39:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/1411063004/#ps140001
(title: "rebase")

[Ryan Hamilton, 2015-10-23 19:40:10]

The CQ bit was unchecked by rch@chromium.org

[commit-bot: I haz the power, 2015-10-23 19:40:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411063004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411063004/140001

[Ryan Hamilton, 2015-10-24 18:58:27]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-10-24 18:58:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org, mef@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/1411063004/#ps200001
(title: "Fix ASAN")

[commit-bot: I haz the power, 2015-10-24 18:58:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411063004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411063004/200001

[commit-bot: I haz the power, 2015-10-24 20:57:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-24 20:57:38]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Ryan Hamilton, 2015-10-26 13:43:35]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-10-26 13:43:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org, mef@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/1411063004/#ps300001
(title: "enough!")

[commit-bot: I haz the power, 2015-10-26 13:43:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411063004/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411063004/300001

[commit-bot: I haz the power, 2015-10-26 14:46:09]

Committed patchset #16 (id:300001)

[commit-bot: I haz the power, 2015-10-26 14:47:03]

Patchset 16 (id:??) landed as
https://crrev.com/1fe2eeb3fc63f3bce4793333ed59e1f3fe94e02c
Cr-Commit-Position: refs/heads/master@{#356047}