net/quic/quic_chromium_client_session_test.cc - Issue 1411063004: Remove insecure QUIC support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_chromium_client_session_test.cc

Issue 1411063004: Remove insecure QUIC support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_server_properties_manager_unittest.cc ('K') | « net/quic/quic_chromium_client_session.cc ('k') | net/quic/quic_connection.h » ('j') | net/tools/quic/end_to_end_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/quic_chromium_client_session_test.cc

diff --git a/net/quic/quic_chromium_client_session_test.cc b/net/quic/quic_chromium_client_session_test.cc

index de9fed16c4ad2d9651b36d5a39016742c1bf319c..61d066a78551731173d21b6d310e2c65a2fba348 100644

--- a/net/quic/quic_chromium_client_session_test.cc

+++ b/net/quic/quic_chromium_client_session_test.cc

@@ -46,7 +46,8 @@ class QuicChromiumClientSessionTest

: public ::testing::TestWithParam<QuicVersion> {

protected:

QuicChromiumClientSessionTest()

- : connection_(new PacketSavingConnection(&helper_,

+ : crypto_config_(CryptoTestUtils::ProofVerifierForTesting()),

+ connection_(new PacketSavingConnection(&helper_,

Perspective::IS_CLIENT,

SupportedVersions(GetParam()))),

session_(connection_,

@@ -58,7 +59,6 @@ class QuicChromiumClientSessionTest

make_scoped_ptr((QuicServerInfo*)nullptr),

QuicServerId(kServerHostname,

kServerPort,

- /*is_secure=*/false,

PRIVACY_MODE_DISABLED),

kQuicYieldAfterPacketsRead,

QuicTime::Delta::FromMilliseconds(

@@ -96,6 +96,7 @@ class QuicChromiumClientSessionTest

}

MockHelper helper_;

+ QuicCryptoClientConfig crypto_config_;

PacketSavingConnection* connection_;

TestNetLog net_log_;

MockClientSocketFactory socket_factory_;

@@ -106,7 +107,6 @@ class QuicChromiumClientSessionTest

MockRandom random_;

QuicConnectionVisitorInterface* visitor_;

TestCompletionCallback callback_;

- QuicCryptoClientConfig crypto_config_;

};

INSTANTIATE_TEST_CASE_P(Tests,

« net/http/http_server_properties_manager_unittest.cc ('K') | « net/quic/quic_chromium_client_session.cc ('k') | net/quic/quic_connection.h » ('j') | net/tools/quic/end_to_end_test.cc » ('J')