Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1411043006: Extend SVG attribute interpolation test helper to test composition modes (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_testHarnessSVGTests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend SVG attribute interpolation test helper to test composition modes This change adds additional parameters to assertAttributeInterpolation(): - underlying - fromComposite - toComposite These enable us to test composition of animations on underlying values for SVG attribute animations. This patch includes a failing test case as we are yet to implement SVG attribute animation composition via Web Animations. BUG=530436 Committed: https://crrev.com/f850b9fff8851dc876dd754f6e0d268d7d69f936 Cr-Commit-Position: refs/heads/master@{#357349}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review changes and expectations updates #

Patch Set 3 : Update expectatiotnpants #

Messages

Total messages: 18 (8 generated)
alancutter (OOO until 2018)
5 years, 1 month ago (2015-10-30 10:09:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411043006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411043006/1
5 years, 1 month ago (2015-10-30 10:11:46 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/128116)
5 years, 1 month ago (2015-10-30 11:14:14 UTC) #6
dstockwell
lgtm https://codereview.chromium.org/1411043006/diff/1/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition-expected.txt File third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition-expected.txt (right): https://codereview.chromium.org/1411043006/diff/1/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition-expected.txt#newcode4 third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition-expected.txt:4: PASS SMIL: Interpolate attribute <offset> add from [-0.5] ...
5 years, 1 month ago (2015-11-02 03:06:24 UTC) #7
alancutter (OOO until 2018)
https://codereview.chromium.org/1411043006/diff/1/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition-expected.txt File third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition-expected.txt (right): https://codereview.chromium.org/1411043006/diff/1/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition-expected.txt#newcode4 third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition-expected.txt:4: PASS SMIL: Interpolate attribute <offset> add from [-0.5] add ...
5 years, 1 month ago (2015-11-02 03:24:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411043006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411043006/20001
5 years, 1 month ago (2015-11-02 10:33:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/128875)
5 years, 1 month ago (2015-11-02 11:23:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411043006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411043006/40001
5 years, 1 month ago (2015-11-02 13:41:15 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-02 14:37:21 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 14:38:01 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f850b9fff8851dc876dd754f6e0d268d7d69f936
Cr-Commit-Position: refs/heads/master@{#357349}

Powered by Google App Engine
This is Rietveld 408576698