Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1410953002: Suppression for valgrind bug (Closed)

Created:
5 years, 2 months ago by scroggo
Modified:
5 years, 2 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Suppression for valgrind bug TBR=msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4478 Committed: https://skia.googlesource.com/skia/+/82e341ff8764ef6168a0c9322089c391d657ae7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/valgrind.supp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410953002/1
5 years, 2 months ago (2015-10-16 21:42:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/82e341ff8764ef6168a0c9322089c391d657ae7f
5 years, 2 months ago (2015-10-16 21:42:50 UTC) #3
msarett
I think we may want to try reverting this to see if the valgrind bot ...
5 years, 2 months ago (2015-10-22 14:08:32 UTC) #4
scroggo
On 2015/10/22 14:08:32, msarett wrote: > I think we may want to try reverting this ...
5 years, 2 months ago (2015-10-22 14:21:56 UTC) #5
scroggo
5 years, 2 months ago (2015-10-22 14:23:06 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1406333006/ by scroggo@google.com.

The reason for reverting is: We believe this was suppressing an out of date
error that was being triggered because the valgrind bot was not rebuilding
nanobench. The valgrind bot has been fixed (is there a bug tracking that?), so
this suppression is probably not necessary..

Powered by Google App Engine
This is Rietveld 408576698