Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2996)

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp

Issue 1410873009: Add a test for the HexDecode method. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp
diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..f01e21293c62f81d12b04682cbc56e68335f04e0
--- /dev/null
+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp
@@ -0,0 +1,52 @@
+// Copyright 2015 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+#include "../../../include/fpdfapi/fpdf_parser.h"
+
+TEST(fpdf_parser_decode, HexDecode) {
+ {
+ // Empty src string.
+ uint8_t* dest = nullptr;
+ FX_DWORD dest_size;
+ uint8_t src[] = "";
+ EXPECT_EQ(0, HexDecode(src, 0, dest, dest_size));
+ EXPECT_EQ(0, dest_size);
+ EXPECT_EQ('\0', dest[0]);
+ }
+
+ {
+ // Regular conversion.
+ uint8_t* dest = nullptr;
+ FX_DWORD dest_size;
+ uint8_t src[] = "12Ac>zzz";
+ EXPECT_EQ(5, HexDecode(src, 8, dest, dest_size));
+ EXPECT_EQ(2, dest_size);
+ EXPECT_EQ(18, dest[0]);
+ EXPECT_EQ(172, dest[1]);
+ }
+
+ {
+ // Non-multiple length.
+ uint8_t* dest = nullptr;
+ FX_DWORD dest_size;
+ uint8_t src[] = "12A>zzz";
+ EXPECT_EQ(4, HexDecode(src, 8, dest, dest_size));
+ EXPECT_EQ(2, dest_size);
+ EXPECT_EQ(18, dest[0]);
+ EXPECT_EQ(160, dest[1]);
+ }
+
+ {
+ // Skips unknown characters.
+ uint8_t* dest = nullptr;
+ FX_DWORD dest_size;
+ uint8_t src[] = "12tk \tAc>zzz";
+ EXPECT_EQ(10, HexDecode(src, 13, dest, dest_size));
+ EXPECT_EQ(2, dest_size);
+ EXPECT_EQ(18, dest[0]);
+ EXPECT_EQ(172, dest[1]);
+ }
+}
« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698