Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410863006: Update sample to use new perlin noise shader, and make cloud like (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
Reviewers:
bsalomon, ethannicholas
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update sample to use new perlin noise shader, and make cloud like BUG=skia: Committed: https://skia.googlesource.com/skia/+/478c04efb352e84e8ccbf633ba5b352c28a12012

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 1

Patch Set 3 : more nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M gyp/SampleApp.gyp View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M samplecode/PerlinPatch.cpp View 1 4 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
egdaniel
5 years, 1 month ago (2015-11-09 15:20:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410863006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410863006/20001
5 years, 1 month ago (2015-11-09 15:20:45 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-09 15:20:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/4107) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 1 month ago (2015-11-09 15:22:54 UTC) #7
ethannicholas
LGTM with nit https://codereview.chromium.org/1410863006/diff/20001/gyp/SampleApp.gyp File gyp/SampleApp.gyp (right): https://codereview.chromium.org/1410863006/diff/20001/gyp/SampleApp.gyp#newcode135 gyp/SampleApp.gyp:135: # PerlinNosie2 typo :-)
5 years, 1 month ago (2015-11-09 15:23:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410863006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410863006/40001
5 years, 1 month ago (2015-11-09 15:30:23 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 15:40:52 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/478c04efb352e84e8ccbf633ba5b352c28a12012

Powered by Google App Engine
This is Rietveld 408576698