tools/dom/scripts/systemnative.py - Issue 1410853005: Wrap DomStringList, but don't wrap DomString[] as return types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 1410853005: Wrap DomStringList, but don't wrap DomString[] as return types (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/systemnative.py

diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py

index 0e16172cbf613e81a46821a037e786c27451f80f..3fc06384edf4aab891f5a46bdae9260e984d2520 100644

--- a/tools/dom/scripts/systemnative.py

+++ b/tools/dom/scripts/systemnative.py

@@ -1753,9 +1753,7 @@ class DartiumBackend(HtmlDartGenerator):

elif wrap_unwrap_list[0]:

jso_util_method = 'wrap_jso'

- # Always return List<String> unwrapped.

- if return_type != 'List<String>':

- emit_template = emit_jso_template % jso_util_method

+ emit_template = emit_jso_template % jso_util_method

if caller_emitter:

caller_emitter.Emit(emit_template,

« no previous file with comments | « tools/dom/scripts/generator.py ('k') | no next file » | no next file with comments »