tools/dom/scripts/generator.py - Issue 1410853005: Wrap DomStringList, but don't wrap DomString[] as return types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/generator.py

Issue 1410853005: Wrap DomStringList, but don't wrap DomString[] as return types (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/generator.py

diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py

index 6f31a7d397e127d594f2c87b51d2656a20a1af2d..2cdc750cb08df551f60a4c1c003a785f62db9a7d 100644

--- a/tools/dom/scripts/generator.py

+++ b/tools/dom/scripts/generator.py

@@ -1447,7 +1447,7 @@ def wrap_unwrap_type_blink(return_type, type_registry):

return_type == 'SqlDatabase' or # renamed to Database

return_type == 'HTMLElement' or

return_type == 'MutationObserver' or

- return_type.endswith('[]'))

+ (return_type.endswith('[]') and return_type != 'DOMString[]'))

def wrap_type_blink(return_type, type_registry):

"""Returns True if the type is a blink type that requires wrap_jso but