Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 14108004: Expose loadTiming information for DRT (Closed)

Created:
7 years, 8 months ago by Pan
Modified:
7 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Expose loadTiming information for DRT Currently in Webkit layout tests, net::LoadTimingInfo is not populated through ResourceLoaderBridge, it affects ResourceTiming & NavigationTiming layout tests. Contributed by pan.deng@intel.com BUG=234867 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199160

Patch Set 1 #

Patch Set 2 : Apply chromium code style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Pan
This blocks ResourceTiming related issue https://codereview.chromium.org/13912021 please review. :) thanks Pan
7 years, 8 months ago (2013-04-23 08:36:36 UTC) #1
mmenke
LGTM
7 years, 8 months ago (2013-04-23 12:09:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/14108004/1
7 years, 8 months ago (2013-04-23 13:26:46 UTC) #3
commit-bot: I haz the power
Presubmit check for 14108004-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-23 13:26:48 UTC) #4
Pan
@darin, could you please help reivew this? I need your LGTM :) thanks Pan
7 years, 8 months ago (2013-04-24 03:07:50 UTC) #5
Pan
blink part CL https://codereview.chromium.org/14851006 has landed, we should fix this issue to make http/tests/misc/webtiming-ssl.php pass. ...
7 years, 7 months ago (2013-05-08 08:49:20 UTC) #6
darin (slow to review)
LGTM
7 years, 7 months ago (2013-05-08 16:21:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/14108004/8001
7 years, 7 months ago (2013-05-08 23:02:16 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 07:40:45 UTC) #9
Message was sent while issue was closed.
Change committed as 199160

Powered by Google App Engine
This is Rietveld 408576698