Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 14851006: Maintain webtiming test case (Closed)

Created:
7 years, 7 months ago by James Simonsen
Modified:
7 years, 7 months ago
Reviewers:
tonyg
CC:
blink-reviews, Pan
Visibility:
Public.

Description

Maintain webtiming test case Modify expected text of http/tests/misc/webtiming-ssl.php, and add expect failure in TestExpectations. This case should fail because resource load timing info is not passed to DRT. Once the chromium change https://codereview.chromium.org/14108004/ is made, this case will pass. Contributed by pan.deng@intel.com BUG=234867 TBR=tonyg Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149830

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/misc/webtiming-ssl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
James Simonsen
7 years, 7 months ago (2013-05-07 00:19:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonjam@chromium.org/14851006/1
7 years, 7 months ago (2013-05-07 00:19:23 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-07 00:19:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonjam@chromium.org/14851006/5001
7 years, 7 months ago (2013-05-07 00:22:22 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 00:57:38 UTC) #5
Message was sent while issue was closed.
Change committed as 149830

Powered by Google App Engine
This is Rietveld 408576698