src/base/logging.h - Issue 1410713006: Unreachable should call V8_Fatal on release builds instead of silently ignoring the error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/logging.h

Issue 1410713006: Unreachable should call V8_Fatal on release builds instead of silently ignoring the error. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/base/logging.h

diff --git a/src/base/logging.h b/src/base/logging.h

index 8a9caacb67ab6db0045fe0197b84cce2a7d11927..e4e3f49bfaffa645d575a000e396ca5fd586e871 100644

--- a/src/base/logging.h

+++ b/src/base/logging.h

@@ -29,7 +29,7 @@ extern "C" V8_NORETURN void V8_Fatal(const char* file, int line,

V8_Fatal("", 0, "%s", (msg))

#define UNIMPLEMENTED() \

V8_Fatal("", 0, "unimplemented code")

-#define UNREACHABLE() ((void) 0)

+#define UNREACHABLE() V8_Fatal("", 0, "unreachable code")

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »