Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: src/base/logging.h

Issue 1410713006: Unreachable should call V8_Fatal on release builds instead of silently ignoring the error. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_BASE_LOGGING_H_ 5 #ifndef V8_BASE_LOGGING_H_
6 #define V8_BASE_LOGGING_H_ 6 #define V8_BASE_LOGGING_H_
7 7
8 #include <cstring> 8 #include <cstring>
9 #include <sstream> 9 #include <sstream>
10 #include <string> 10 #include <string>
(...skipping 11 matching lines...) Expand all
22 V8_Fatal(__FILE__, __LINE__, "%s", (msg)) 22 V8_Fatal(__FILE__, __LINE__, "%s", (msg))
23 #define UNIMPLEMENTED() \ 23 #define UNIMPLEMENTED() \
24 V8_Fatal(__FILE__, __LINE__, "unimplemented code") 24 V8_Fatal(__FILE__, __LINE__, "unimplemented code")
25 #define UNREACHABLE() \ 25 #define UNREACHABLE() \
26 V8_Fatal(__FILE__, __LINE__, "unreachable code") 26 V8_Fatal(__FILE__, __LINE__, "unreachable code")
27 #else 27 #else
28 #define FATAL(msg) \ 28 #define FATAL(msg) \
29 V8_Fatal("", 0, "%s", (msg)) 29 V8_Fatal("", 0, "%s", (msg))
30 #define UNIMPLEMENTED() \ 30 #define UNIMPLEMENTED() \
31 V8_Fatal("", 0, "unimplemented code") 31 V8_Fatal("", 0, "unimplemented code")
32 #define UNREACHABLE() ((void) 0) 32 #define UNREACHABLE() V8_Fatal("", 0, "unreachable code")
33 #endif 33 #endif
34 34
35 35
36 namespace v8 { 36 namespace v8 {
37 namespace base { 37 namespace base {
38 38
39 // CHECK dies with a fatal error if condition is not true. It is *not* 39 // CHECK dies with a fatal error if condition is not true. It is *not*
40 // controlled by DEBUG, so the check will be executed regardless of 40 // controlled by DEBUG, so the check will be executed regardless of
41 // compilation mode. 41 // compilation mode.
42 // 42 //
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 #define DCHECK_GT(v1, v2) ((void) 0) 168 #define DCHECK_GT(v1, v2) ((void) 0)
169 #define DCHECK_GE(v1, v2) ((void) 0) 169 #define DCHECK_GE(v1, v2) ((void) 0)
170 #define DCHECK_LT(v1, v2) ((void) 0) 170 #define DCHECK_LT(v1, v2) ((void) 0)
171 #define DCHECK_LE(v1, v2) ((void) 0) 171 #define DCHECK_LE(v1, v2) ((void) 0)
172 #define DCHECK_NULL(val) ((void) 0) 172 #define DCHECK_NULL(val) ((void) 0)
173 #define DCHECK_NOT_NULL(val) ((void) 0) 173 #define DCHECK_NOT_NULL(val) ((void) 0)
174 #define DCHECK_IMPLIES(v1, v2) ((void) 0) 174 #define DCHECK_IMPLIES(v1, v2) ((void) 0)
175 #endif 175 #endif
176 176
177 #endif // V8_BASE_LOGGING_H_ 177 #endif // V8_BASE_LOGGING_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698