Issue 1410683013: Merge to XFA: Cleanup some fxge font code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1410683013: Merge to XFA: Cleanup some fxge font code. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+416 lines, -452 lines)			Patch
M	core/include/fxge/fx_font.h	View		4 chunks	+14 lines, -10 lines	0 comments	Download
M	core/src/fxge/ge/fx_ge_fontmap.cpp	View		18 chunks	+395 lines, -436 lines	0 comments	Download
M	core/src/fxge/ge/fx_ge_text.cpp	View	1	4 chunks	+7 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

TBR. Small conflict in core/src/fxge/ge/fx_ge_text.cpp because the XFA version does not use ScopedFontTransform.

5 years, 1 month ago (2015-11-09 18:47:56 UTC) #1

Lei Zhang

5 years, 1 month ago (2015-11-09 18:48:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3beeeeeb2ca45d54b34e4cc80fb137980e2f7aae (presubmit successful).