Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1426403008: Cleanup some fxge font code. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 12

Patch Set 2 : rebase #

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -453 lines) Patch
M core/include/fxge/fx_font.h View 1 2 4 chunks +14 lines, -10 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 18 chunks +395 lines, -436 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
https://codereview.chromium.org/1426403008/diff/1/core/src/fxge/ge/fx_ge_fontmap.cpp File core/src/fxge/ge/fx_ge_fontmap.cpp (left): https://codereview.chromium.org/1426403008/diff/1/core/src/fxge/ge/fx_ge_fontmap.cpp#oldcode498 core/src/fxge/ge/fx_ge_fontmap.cpp:498: CFX_ByteString _FPDF_LoadTableFromTTStreamFile(IFX_FileStream* pFile, Dead https://codereview.chromium.org/1426403008/diff/1/core/src/fxge/ge/fx_ge_fontmap.cpp#oldcode632 core/src/fxge/ge/fx_ge_fontmap.cpp:632: FX_DWORD _GetCodePageRangeFromCharset(int charset) ...
5 years, 1 month ago (2015-11-07 01:32:18 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1426403008/diff/1/core/include/fxge/fx_font.h File core/include/fxge/fx_font.h (right): https://codereview.chromium.org/1426403008/diff/1/core/include/fxge/fx_font.h#newcode403 core/include/fxge/fx_font.h:403: FXFT_Face const m_Face; nit: Someday we'll lose the ...
5 years, 1 month ago (2015-11-09 18:05:18 UTC) #3
Lei Zhang
https://codereview.chromium.org/1426403008/diff/1/core/include/fxge/fx_font.h File core/include/fxge/fx_font.h (right): https://codereview.chromium.org/1426403008/diff/1/core/include/fxge/fx_font.h#newcode403 core/include/fxge/fx_font.h:403: FXFT_Face const m_Face; On 2015/11/09 18:05:17, Tom Sepez wrote: ...
5 years, 1 month ago (2015-11-09 18:41:03 UTC) #4
Lei Zhang
5 years, 1 month ago (2015-11-09 18:42:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
94a4956f7aadc10fe6dd8451e965bd7447985b76 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698