Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1410683002: Add some components to "gn check" (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, wjmaclean, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some components to "gn check" Adds translate, ui/zoom, upload_list, visitedlink, web_resource, webusb Makes CLD 2 forward public deps properly Committed: https://crrev.com/3ceb2d9e5d85f364256981ae370503411618f666 Cr-Commit-Position: refs/heads/master@{#354453}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -20 lines) Patch
M .gn View 1 chunk +10 lines, -1 line 0 comments Download
M components/translate/content/browser/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M components/translate/core/browser/BUILD.gn View 1 3 chunks +23 lines, -13 lines 0 comments Download
M components/translate/core/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/translate/core/language_detection/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/ui/zoom/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/upload_list/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/visitedlink/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/visitedlink/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/visitedlink/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/web_resource/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/webusb/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/cld_2/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
brettw
Kind of random, but I want to add "components/*" to the whitelist soonish so that ...
5 years, 2 months ago (2015-10-15 23:13:08 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410683002/1
5 years, 2 months ago (2015-10-15 23:13:10 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/128331) win_chromium_compile_dbg_ng on ...
5 years, 2 months ago (2015-10-15 23:16:34 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410683002/20001
5 years, 2 months ago (2015-10-15 23:45:07 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 00:29:53 UTC) #10
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-16 01:30:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410683002/20001
5 years, 2 months ago (2015-10-16 05:27:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 05:33:12 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 05:34:14 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ceb2d9e5d85f364256981ae370503411618f666
Cr-Commit-Position: refs/heads/master@{#354453}

Powered by Google App Engine
This is Rietveld 408576698