Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: components/translate/core/browser/BUILD.gn

Issue 1410683002: Add some components to "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/content/browser/BUILD.gn ('k') | components/translate/core/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/BUILD.gn
diff --git a/components/translate/core/browser/BUILD.gn b/components/translate/core/browser/BUILD.gn
index 862a6b85491298d57b25ba4d959befc638ec8528..2fafccc3b99f39f4e3bb13c6fa493c15124bed3d 100644
--- a/components/translate/core/browser/BUILD.gn
+++ b/components/translate/core/browser/BUILD.gn
@@ -37,11 +37,29 @@ source_set("browser") {
"translate_url_util.h",
]
+ deps = [
+ "//base",
+ "//base:i18n",
+ "//base:prefs",
+ "//components/data_use_measurement/core",
+ "//components/language_usage_metrics",
+ "//components/pref_registry",
+ "//components/resources:components_resources",
+ "//components/strings",
+ "//components/translate/core/common",
+ "//google_apis",
+ "//net",
+ "//third_party/icu",
+ "//ui/base",
+ "//url",
+ ]
+
if (!use_aura) {
sources += [
"translate_infobar_delegate.cc",
"translate_infobar_delegate.h",
]
+ deps += [ "//components/infobars/core" ]
}
if (is_mac) {
@@ -50,19 +68,6 @@ source_set("browser") {
"options_menu_model.h",
]
}
-
- deps = [
- "//base",
- "//components/data_use_measurement/core",
- "//components/language_usage_metrics",
- "//components/resources:components_resources",
- "//components/strings",
- "//components/translate/core/common",
- "//net",
- "//third_party/icu",
- "//ui/base",
- "//url",
- ]
}
source_set("unit_tests") {
@@ -76,6 +81,11 @@ source_set("unit_tests") {
]
deps = [
":browser",
+ "//base",
+ "//base:prefs",
+ "//components/pref_registry:test_support",
+ "//components/translate/core/common",
+ "//net:test_support",
"//testing/gtest",
]
}
« no previous file with comments | « components/translate/content/browser/BUILD.gn ('k') | components/translate/core/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698