Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 14106011: Allow setting debugger breakpoints on CompareNilICs (Closed)

Created:
7 years, 7 months ago by danno
Modified:
7 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Allow setting debugger breakpoints on CompareNilICs BUG=v8:2660 R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M src/arm/debug-arm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/debug.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/debug-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
lgtm
7 years, 7 months ago (2013-04-30 07:00:49 UTC) #1
danno
7 years, 7 months ago (2013-04-30 07:56:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r14487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698