Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 14106011: Allow setting debugger breakpoints on CompareNilICs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 // ----------- S t a t e ------------- 233 // ----------- S t a t e -------------
234 // -- eax : value 234 // -- eax : value
235 // -- ecx : key 235 // -- ecx : key
236 // -- edx : receiver 236 // -- edx : receiver
237 // ----------------------------------- 237 // -----------------------------------
238 Generate_DebugBreakCallHelper( 238 Generate_DebugBreakCallHelper(
239 masm, eax.bit() | ecx.bit() | edx.bit(), 0, false); 239 masm, eax.bit() | ecx.bit() | edx.bit(), 0, false);
240 } 240 }
241 241
242 242
243 void Debug::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
244 // Register state for CompareNil IC
245 // ----------- S t a t e -------------
246 // -- eax : value
247 // -----------------------------------
248 Generate_DebugBreakCallHelper(masm, eax.bit(), 0, false);
249 }
250
251
243 void Debug::GenerateCallICDebugBreak(MacroAssembler* masm) { 252 void Debug::GenerateCallICDebugBreak(MacroAssembler* masm) {
244 // Register state for keyed IC call call (from ic-ia32.cc) 253 // Register state for keyed IC call call (from ic-ia32.cc)
245 // ----------- S t a t e ------------- 254 // ----------- S t a t e -------------
246 // -- ecx: name 255 // -- ecx: name
247 // ----------------------------------- 256 // -----------------------------------
248 Generate_DebugBreakCallHelper(masm, ecx.bit(), 0, false); 257 Generate_DebugBreakCallHelper(masm, ecx.bit(), 0, false);
249 } 258 }
250 259
251 260
252 void Debug::GenerateReturnDebugBreak(MacroAssembler* masm) { 261 void Debug::GenerateReturnDebugBreak(MacroAssembler* masm) {
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 362
354 const bool Debug::kFrameDropperSupported = true; 363 const bool Debug::kFrameDropperSupported = true;
355 364
356 #undef __ 365 #undef __
357 366
358 #endif // ENABLE_DEBUGGER_SUPPORT 367 #endif // ENABLE_DEBUGGER_SUPPORT
359 368
360 } } // namespace v8::internal 369 } } // namespace v8::internal
361 370
362 #endif // V8_TARGET_ARCH_IA32 371 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/debug.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698