Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1410553006: API: Let v8::Object::DefineOwnProperty use new C++ implementation (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

API: Let v8::Object::DefineOwnProperty use new C++ implementation Now that we have a C++ implementation, calling into JS builtins is needlessly inefficient. Committed: https://crrev.com/406f557721419060c326f6ac3851ae6fb013aaf7 Cr-Commit-Position: refs/heads/master@{#31637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -30 lines) Patch
M src/api.cc View 3 chunks +13 lines, -17 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/v8natives.js View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL.
5 years, 1 month ago (2015-10-28 16:14:41 UTC) #3
Camillo Bruni
lgtm
5 years, 1 month ago (2015-10-28 16:21:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410553006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410553006/1
5 years, 1 month ago (2015-10-28 16:23:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 16:48:58 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 16:49:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/406f557721419060c326f6ac3851ae6fb013aaf7
Cr-Commit-Position: refs/heads/master@{#31637}

Powered by Google App Engine
This is Rietveld 408576698