Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: src/js/v8natives.js

Issue 1410553006: API: Let v8::Object::DefineOwnProperty use new C++ implementation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/contexts.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/v8natives.js
diff --git a/src/js/v8natives.js b/src/js/v8natives.js
index 3c1e175a9e7f4f1bd8b23678b85c6722ea1d9f9a..2985d143f9937a60b467fb938d974928d16e9ad7 100644
--- a/src/js/v8natives.js
+++ b/src/js/v8natives.js
@@ -866,17 +866,6 @@ function DefineOwnProperty(obj, p, desc, should_throw) {
}
-function DefineOwnPropertyFromAPI(obj, p, value, desc) {
- return DefineOwnProperty(obj, p, ToPropertyDescriptor({
- value: value,
- writable: desc[0],
- enumerable: desc[1],
- configurable: desc[2]
- }),
- false);
-}
-
-
// ES6 section 19.1.2.9
function ObjectGetPrototypeOf(obj) {
return %_GetPrototype(TO_OBJECT(obj));
@@ -1860,7 +1849,6 @@ utils.Export(function(to) {
"global_eval_fun", GlobalEval,
"object_value_of", ObjectValueOf,
"object_to_string", ObjectToString,
- "object_define_own_property", DefineOwnPropertyFromAPI,
"object_get_own_property_descriptor", ObjectGetOwnPropertyDescriptor,
"to_complete_property_descriptor", ToCompletePropertyDescriptor,
]);
« no previous file with comments | « src/contexts.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698