Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: chrome/installer/test/alternate_version_generator.cc

Issue 14105014: Fix disabled InstallerStateTest.RemoveOldVersionDirs on x64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/util/installer_state_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/test/alternate_version_generator.cc
diff --git a/chrome/installer/test/alternate_version_generator.cc b/chrome/installer/test/alternate_version_generator.cc
index 9e54561ca96640f37ba28626fbaa13ecbaf58227..7811be4455d15b90ff6f8c704c8b9094f0637d4c 100644
--- a/chrome/installer/test/alternate_version_generator.cc
+++ b/chrome/installer/test/alternate_version_generator.cc
@@ -179,7 +179,7 @@ bool MappedFile::Initialize(base::PlatformFile file) {
if (base::GetPlatformFileInfo(file, &file_info)) {
if (file_info.size <=
- static_cast<int64>(std::numeric_limits<size_t>::max())) {
+ static_cast<int64>(std::numeric_limits<DWORD>::max())) {
robertshield 2013/04/29 20:04:45 Really curious: how does this fix the test?
mapping_ = CreateFileMapping(file, NULL, PAGE_READWRITE, 0,
static_cast<DWORD>(file_info.size), NULL);
if (mapping_ != NULL) {
@@ -194,7 +194,7 @@ bool MappedFile::Initialize(base::PlatformFile file) {
PLOG(DFATAL) << "CreateFileMapping failed";
}
} else {
- LOG(DFATAL) << "Files larger than " << std::numeric_limits<size_t>::max()
+ LOG(DFATAL) << "Files larger than " << std::numeric_limits<DWORD>::max()
<< " are not supported.";
}
} else {
« no previous file with comments | « no previous file | chrome/installer/util/installer_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698