Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: chrome/installer/util/installer_state_unittest.cc

Issue 14105014: Fix disabled InstallerStateTest.RemoveOldVersionDirs on x64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/installer_state_unittest.cc
diff --git a/chrome/installer/util/installer_state_unittest.cc b/chrome/installer/util/installer_state_unittest.cc
index 5395a8492cc298b58468bab48f9bcec707520008..0f985f889c5c4923e5a2bad850b8d10270f7fc8e 100644
--- a/chrome/installer/util/installer_state_unittest.cc
+++ b/chrome/installer/util/installer_state_unittest.cc
@@ -496,15 +496,7 @@ TEST_F(InstallerStateTest, IsFileInUse) {
EXPECT_FALSE(MockInstallerState::IsFileInUse(temp_file));
}
-// TODO(jschuh): crbug.com/167707 need to fix Win64 pe_image issues due to
-// calling upgrade_test::GenerateSpecificPEFileVersion
-#if defined(OS_WIN) && defined(ARCH_CPU_X86_64)
-#define MAYBE_RemoveOldVersionDirs DISABLED_RemoveOldVersionDirs
-#else
-#define MAYBE_RemoveOldVersionDirs RemoveOldVersionDirs
-#endif
-
-TEST_F(InstallerStateTest, MAYBE_RemoveOldVersionDirs) {
+TEST_F(InstallerStateTest, RemoveOldVersionDirs) {
MockInstallerState installer_state;
installer_state.set_target_path(test_dir_.path());
EXPECT_EQ(test_dir_.path().value(), installer_state.target_path().value());

Powered by Google App Engine
This is Rietveld 408576698