Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/crash/content/app/breakpad_win.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/installer/util/shell_util.cc ('K') | « components/browser_watcher/exit_funnel_win.cc ('k') | components/crash/content/app/crash_keys_win.cc » ('j') | content/browser/accessibility/accessibility_tree_formatter_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/breakpad_win.cc
diff --git a/components/crash/content/app/breakpad_win.cc b/components/crash/content/app/breakpad_win.cc
index 5b53ff791830104f4664e21e25f675b668768576..db62de36f0fcd3337788637bd71bf14b94970462 100644
--- a/components/crash/content/app/breakpad_win.cc
+++ b/components/crash/content/app/breakpad_win.cc
@@ -186,8 +186,9 @@ std::wstring GetProfileType() {
}
}
} else {
- DWORD last_error = ::GetLastError();
- base::SStringPrintf(&profile_type, L"error %u", last_error);
+ // Safe.
+ //DWORD last_error = ::GetLastError();
+ //base::SStringPrintf(&profile_type, L"error %u", last_error);
}
return profile_type;
}
« chrome/installer/util/shell_util.cc ('K') | « components/browser_watcher/exit_funnel_win.cc ('k') | components/crash/content/app/crash_keys_win.cc » ('j') | content/browser/accessibility/accessibility_tree_formatter_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698